8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() #3507

Wanghuang-Huawei · 2021-04-15T02:57:31Z

aarch64 can only accept VectorReinterpret with 64/128 bits.
I will fix this bug by adding a rule for VectorReinterpret in match_rule_supported_vector
after changing note with @nsjian and @XiaohongGong , I think that two checks in inline_vector_conver is useless now. However, these checks impact other cpus, so I need more reviewers.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert()

Contributors

Wang Huang <whuang@openjdk.org>
Ai Jiaming <aijiaming1@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3507/head:pull/3507
$ git checkout pull/3507

Update a local copy of the PR:
$ git checkout pull/3507
$ git pull https://git.openjdk.java.net/jdk pull/3507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3507

View PR using the GUI difftool:
$ git pr show -t 3507

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3507.diff

bridgekeeper · 2021-04-15T02:57:45Z

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Wanghuang-Huawei · 2021-04-15T02:59:11Z

/contributor add Wang Huang whuang@openjdk.org
/contributor add Ai Jiaming aijiaming1@huawei.com

openjdk · 2021-04-15T02:59:19Z

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2021-04-15T02:59:34Z

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

openjdk · 2021-04-15T03:01:09Z

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

mlbridge · 2021-04-15T03:04:43Z

Webrevs

01: Full - Incremental (522b256f)
00: Full (f65c8671)

Wanghuang-Huawei · 2021-04-15T04:35:12Z

/test

openjdk · 2021-04-15T04:35:57Z

@Wanghuang-Huawei you need to get approval to run the tests in tier1 for commits up until f65c867

Wanghuang-Huawei · 2021-04-17T01:49:06Z

@iwanowww Can you do me a favor to review this patch? Thank you.

neliasso

Please change the bug and PR title to something that describes the problem or solution.

Wanghuang-Huawei · 2021-04-29T08:02:32Z

Please change the bug and PR title to something that describes the problem or solution.

Thank you for your review. I will change that.

XiaohongGong · 2021-04-29T09:08:43Z

src/hotspot/cpu/aarch64/aarch64.ad

@@ -2401,6 +2401,11 @@ const bool Matcher::match_rule_supported_vector(int opcode, int vlen, BasicType
  } else { // NEON
    // Special cases
    switch (opcode) {
+    case Op_VectorReinterpret:
+      if (bit_size != 64 && bit_size != 128) {


bit_size < 64 ?

Reinterpret's size should bit_size == 64 || bit_size == 128

XiaohongGong · 2021-04-29T09:10:53Z

test/hotspot/jtreg/compiler/vectorapi/TestCast4STo2I.java

+ */
+
+public class TestCast4STo2I {
+    static final VectorSpecies<Short> SPECIESs = ShortVector.SPECIES_64;


XiaohongGong · 2021-04-29T09:11:05Z

test/hotspot/jtreg/compiler/vectorapi/TestCast4STo2I.java

+
+public class TestCast4STo2I {
+    static final VectorSpecies<Short> SPECIESs = ShortVector.SPECIES_64;
+    static final VectorSpecies<Integer> SPECIESi = IntVector.SPECIES_64;


XiaohongGong · 2021-04-29T09:12:41Z

test/hotspot/jtreg/compiler/vectorapi/TestCast4STo2I.java

+        for (int i = 0; i < SIZE; i++) {
+            System.out.print(ai[i] + ", ");
+        }


It's better to add the correctness testing as well to make sure the results are right.

theRealAph

Please change the title of this to

8265244: AArch64: Remove useless comparation in LibraryCallKit::inline_vector_convert()

since it affects the AArch64 port. This makes the logs and the mailing lists much easier to read.

Thanks.

Wanghuang-Huawei · 2021-04-30T02:24:22Z

Please change the title of this to

8265244: AArch64: Remove useless comparation in LibraryCallKit::inline_vector_convert()

since it affects the AArch64 port. This makes the logs and the mailing lists much easier to read.

Thanks.

Thank you for your suggestion. There is only one question here:

the comparation

int num_elem_for_cast = MIN2(num_elem_from, Matcher::max_vector_size(elem_bt_to));

which will be removed here can effect all cpus.

theRealAph · 2021-04-30T08:01:32Z

src/hotspot/share/opto/vectorIntrinsics.cpp

@@ -1450,7 +1450,7 @@ bool LibraryCallKit::inline_vector_convert() {
      // Since input and output number of elements are not consistent, we need to make sure we
      // properly size. Thus, first make a cast that retains the number of elements from source.
      // In case the size exceeds the arch size, we do the minimum.


If you're going to remove the MIN2 you must also change this comment.

Sure. I will remove that in next commit.

theRealAph · 2021-04-30T08:01:49Z

src/hotspot/share/opto/vectorIntrinsics.cpp

@@ -1469,7 +1469,7 @@ bool LibraryCallKit::inline_vector_convert() {
    } else if (num_elem_from > num_elem_to) {
      // Since number elements from input is larger than output, simply reduce size of input (we are supposed to
      // drop top elements anyway).


This one too?

mlbridge · 2021-04-30T08:06:29Z

Mailing list message from Andrew Haley on hotspot-compiler-dev:

On 4/30/21 3:26 AM, Wang Huang wrote:

There is only one question here:

the comparation

int num_elem_for_cast = MIN2(num_elem_from, Matcher::max_vector_size(elem_bt_to));

which will be removed here can effect all cpus.

Perhaps so. However, you need to do something with the title because this patch
does not simply remove a useless comparison. You might make life easier for
everyone by splitting this patch into two parts.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

bridgekeeper · 2021-05-28T12:01:23Z

@Wanghuang-Huawei This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2021-06-25T12:06:21Z

@Wanghuang-Huawei This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

8265244: assert(false) failed: bad AD file

f65c867

openjdk bot added the rfr Pull request is ready for review label Apr 15, 2021

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 15, 2021

openjdk bot added the test-request label Apr 15, 2021

Merge branch 'master' into JDK-8265244

522b256

neliasso reviewed Apr 28, 2021

View reviewed changes

Wanghuang-Huawei changed the title ~~8265244: assert(false) failed: bad AD file~~ 8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() Apr 29, 2021

XiaohongGong reviewed Apr 29, 2021

View reviewed changes

theRealAph reviewed Apr 29, 2021

View reviewed changes

theRealAph reviewed Apr 30, 2021

View reviewed changes

bridgekeeper bot closed this Jun 25, 2021

Wanghuang-Huawei mentioned this pull request Aug 18, 2021

8272413: Incorrect num of element count calculation for vector cast #5160

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() #3507

8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() #3507

Wanghuang-Huawei commented Apr 15, 2021 •

edited by openjdk bot

bridgekeeper bot commented Apr 15, 2021

Wanghuang-Huawei commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

mlbridge bot commented Apr 15, 2021 •

edited

Wanghuang-Huawei commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

Wanghuang-Huawei commented Apr 17, 2021

neliasso left a comment

Wanghuang-Huawei commented Apr 29, 2021

XiaohongGong Apr 29, 2021

Wanghuang-Huawei Apr 29, 2021

XiaohongGong Apr 29, 2021

XiaohongGong Apr 29, 2021

XiaohongGong Apr 29, 2021

theRealAph left a comment

Wanghuang-Huawei commented Apr 30, 2021

theRealAph Apr 30, 2021

Wanghuang-Huawei Apr 30, 2021

theRealAph Apr 30, 2021

mlbridge bot commented Apr 30, 2021

bridgekeeper bot commented May 28, 2021

bridgekeeper bot commented Jun 25, 2021

8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() #3507

8265244: Remove useless comparation in LibraryCallKit::inline_vector_convert() #3507

Conversation

Wanghuang-Huawei commented Apr 15, 2021 • edited by openjdk bot

Progress

Issue

Contributors

Reviewing

bridgekeeper bot commented Apr 15, 2021

Wanghuang-Huawei commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

mlbridge bot commented Apr 15, 2021 • edited

Webrevs

Wanghuang-Huawei commented Apr 15, 2021

openjdk bot commented Apr 15, 2021

Wanghuang-Huawei commented Apr 17, 2021

neliasso left a comment

Choose a reason for hiding this comment

Wanghuang-Huawei commented Apr 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theRealAph left a comment

Choose a reason for hiding this comment

Wanghuang-Huawei commented Apr 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlbridge bot commented Apr 30, 2021

bridgekeeper bot commented May 28, 2021

bridgekeeper bot commented Jun 25, 2021

Wanghuang-Huawei commented Apr 15, 2021 •

edited by openjdk bot

mlbridge bot commented Apr 15, 2021 •

edited